perf(size): Compute zip metadata size without building a zip - #697
Open
NicoHinderling wants to merge 1 commit into
Open
NicoHinderling wants to merge 1 commit into
NicoHinderling wants to merge 1 commit into
Conversation
The download-size estimate compressed the whole app bundle into a temp zip only to read back its header sizes. Those depend only on entry names and count, so compute them directly. Results are byte-identical on all bundles tested, and a large app drops from about 8s to 0.2s. zip_directory no longer needs its follow-symlinks mode, so remove it.
Contributor
Size Analysis1 component analyzed, 1 component processing iOS Builds
Android Builds
|
Contributor
📲 Install BuildsiOS
Android
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #692. The Apple download-size estimate still compresses the whole app bundle into a temp zip just to read back its header sizes, which only depend on file names and file count. This computes that number directly instead.
zip_directory's follow-symlinks mode, which only this code used, and skips symlinks that loop back to a parent folder (previously a hang).